Repository navigation
fix: preserve .data route params in v7 single fetch requests - #15734
Draft
brophdawg11 wants to merge 1 commit into
Draft
brophdawg11 wants to merge 1 commit into
brophdawg11 wants to merge 1 commit into
Conversation
Contributor
Preview Build AvailablePreview builds have been created for this PR. You can install pnpm install "remix-run/react-router#preview/pr-15734&path:packages/react-router"And/or install other packages via: pnpm install "remix-run/react-router#preview/pr-15734&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15734&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15734&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15734&path:packages/react-router-serve"These preview builds will be updated automatically as you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v7 Framework Mode with
future.v8_passThroughRequestsdisabled,/items/foo.data.datais normalized twice, so loaders and actions receiveparams.id === "foo"instead of"foo.data".Normalize the original request for route matching to preserve the
.datasuffix in route parameters and the normalizedurlargument, while retaining v7's existingrequest.urlbehavior. Requests with pass-through enabled and v8 are unaffected.Closes #15733
Authored by an AI agent on behalf of @brophdawg11